Prototype for repository findBy type checking. #109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've wanted to have
ObjectRepository::findBy
type check the criteria for a while now, and I finally got around to working out a prototype. There are still several major problems:RepositoryParamsProviderClassPopulator
is a workaround that severely abuses the api to allow providing return types for inherited methods.MethodCall
statement and it works fine.EntityManager
, which requires a database connection, which I would like to avoid. Even when creating and populating theClassMetadata
directly it uses the Reflection api, which means everything being analyzed has to be autoloadable.All that being said, I tested it on a Symfony project and it worked quite well. Unfortunately I'm not really sure where to go from here.