Support paged cgm #270
Support paged cgm #270
Conversation
Add GlucosePage CRC check tests and Data extension to reverseBytes since GlucosePages are easier to decode in reverse.
In writing this test and the code that passed the test, I encountered a strange mismatch from decocare. Decocare had more sgv entries, but they had values of 0. Additional discovery and discussion led to a change in decocare: openaps/decocare#11
Independent glucose events are events that have a timestamp in the record and do not serve as a reference timestamp for other records.
Reference timestamped records are used to apply a timestamp to other records using an offset (5 minutes).
Relative timestamp records need a timestamp, but don’t have one in their own raw data, so that’s not included in this commit.
Clean up test output a little to help in troubleshooting
| @@ -71,6 +71,14 @@ extension Data { | |||
| */ | |||
| } | |||
|
|
|||
| extension Data { | |||
| func reverseBytes() -> Data { | |||
There was a problem hiding this comment.
There is a method in the standard library to do this already. See https://developer.apple.com/reference/foundation/data/1780245-reversed
There was a problem hiding this comment.
I'm having trouble figuring out what to do with the data structure that reversed() gives me. It's a ReversedRandomAccessCollection<Data>, and it looks like I have to use a different Index structure. The change seems to leak all the way through to how I access rawData GlucoseEvent and seems messy. Can you take a look and help me understand how to appropriately use reversed() on the page Data?
There was a problem hiding this comment.
You can use Data(data.reversed()) to create a new reversed data object. There may be ways to work with RandomAccessCollection types, and avoid the copy, but I wasn't able to get that working in my swift playground.
There was a problem hiding this comment.
Thanks! Change made.
| var events = [TimestampedGlucoseEvent]() | ||
|
|
||
| // Going to scan backwards in time through events, so event time should be monotonically decreasing. | ||
| let eventTimestampDeltaAllowance = TimeInterval(hours: 9) |
There was a problem hiding this comment.
This should not be necessary, unless you have encountered out of order glucose events, and need to keep looking back further in history to ensure you get all events since startDate.
There was a problem hiding this comment.
There are out of order events due to relative timestamping. I changed the timestamp check on f266ebb#diff-bf2d04fbde756ea81dd46dafafbdacddR589 to use the reference timestamped events only. That should ensure that all relevant glucose events are captured since startDate at the expense of maybe capturing a few extra independently timestamped (non-sgv) entries.
| idx = top | ||
| } | ||
|
|
||
| let page = try GlucosePage(pageData: pageData, pumpModel: pumpModel) |
There was a problem hiding this comment.
I searched and didn't see any actual dependency on pumpModel in the data parsing. Can this be removed?
tmecklem
force-pushed
the
support-paged-cgm
branch
from
6044206
to
6ce4626
Compare
Glucose events can be out of order (and are frequently). Checking for only reference timestamps should catch all relevant events.
| - failure(error): An error describing why the command failed | ||
|
|
||
| */ | ||
| public func getGlucoseHistoryEvents(since startDate: Date, completion: @escaping (Either<(events: [TimestampedGlucoseEvent], pumpModel: PumpModel), Error>) -> Void) { |
|
I'm planning to get this version of the app installed on the phone of someone using a 722 pump with enlite before the start of the weekend for Real World:tm: testing. |
Summary: Add support for fetching and displaying recent data from cgm pages. See #200
This PR adds to MinimedKit the ability to fetch and decode cgm pages into events similar to the way that history pages are processed. It also supports fetching the pointer to the current page of cgm data to support fetching the most recent pages first.
In RileyLinkKit, functionality is built upon the additions to MinimedKit to fetch recent cgm data from the last 24 hours and display it similarly to the fetch recent history functionality.