Update Ethdo Keystore Deps #7537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
WORKSPACE
Outdated
| @@ -157,7 +157,7 @@ go_rules_dependencies() | |||
|
|
|||
| go_register_toolchains(nogo = "@//:nogo") | |||
|
|
|||
| load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies") | |||
| load("@bazel_gazelle//:deps.bzl", "gazelle_dependencies", "go_repository") | |||
|
Ready again @prestonvanloon |
Codecov Report
@@ Coverage Diff @@
## master #7537 +/- ##
==========================================
- Coverage 61.89% 61.66% -0.24%
==========================================
Files 422 423 +1
Lines 29774 29854 +80
==========================================
- Hits 18430 18410 -20
- Misses 8383 8481 +98
- Partials 2961 2963 +2 |
prestonvanloon
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? Why is it needed?
This PR updates the following ethdo dependencies
This allows us to be fully compliant with the key derivation from the eth2 deposit cli, which uses an updated pbkdf parameter which changes the way seeds derive into private keys. To support users using our current HD wallet, we leverage keystore versions to prevent breaking their current setups.
To ensure that we are backwards compatible, we add a
versionfield to the keymanageropts for the keymanagers. If version is "2", we use the new dependencies to derive and create keystore files, and the old ones otherwise.Which issues(s) does this PR fix?
Fixes #7448
Other notes for review