Fix inaccurate validator balance metrics #6134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
requested changes
Jun 4, 2020
| } | ||
| continue | ||
| } | ||
| prevEpoch := (slot / params.BeaconConfig().SlotsPerEpoch) - 1 |
There was a problem hiding this comment.
How about slot 0? I believe we have a helper func called helpers.PrevEpoch that checks for underflow
There was a problem hiding this comment.
This code doesn't run in epoch 0, but I'll use the helper func.
Ah, but PrevEpoch only takes state.
There was a problem hiding this comment.
lets make a small helper then in this file that checks for underflow
There was a problem hiding this comment.
Added a comment to detail
terencechain
requested changes
Jun 4, 2020
Testing now. Give me 30 mins |
terencechain
previously approved these changes
Jun 4, 2020
|
Just for the sake of defensive programming, always good to check for underflow @0xKiwi |
rauljordan
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This PR solves the issue of validator metrics being inaccurate, previously the validator client was assuming the response from the beacon node was in the same order requested, but it is actually sorted by validator index. This changes the validator client to use the public key response to set the order received.
Fixes #5305 and fixes #5600