Rollback libp2p kad dht dependency update #6084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
changed the title
nisdas
reviewed
Jun 2, 2020
| @@ -2977,3 +2977,213 @@ def prysm_deps(): | |||
| sum = "h1:4Z09Hglb792X0kfOBBJUPFEyvVfQWrYT/l8h5EKA6JQ=", | |||
| version = "v0.0.0-20190525122527-15d366b2352e", | |||
| ) | |||
| go_repository( | |||
There was a problem hiding this comment.
why are all of geth's deps re-imported here ? we are already using a rule for it
There was a problem hiding this comment.
Gazelle did it.
One thing to keep in mind is that this go_repository alias is a "maybe" style import. So if we have already imported geth's dependencies via bazel rule, then this would not override it.
0xKiwi
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
These updates to the libp2p kad-dht have far too many breaking changes for Topaz.
Given that we are planning to remove this functionality entirely in #5864, a simple rollback to the last know working version should resolve the issue for the moment.
Which issues(s) does this PR fix?
Fixes #6077
Other notes for review
Commands run:
go get github.com/libp2p/[email protected] github.com/libp2p/[email protected]bazel run //:gazelle -- update-repos -from_file=go.mod -to_macro=deps.bzl%prysm_depsThere were some API changes as well so there is a slight change in the p2p setup code for discovery via kah dht.