Adhere to ETH1 Follow Distance #5941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
requested review from
rauljordan,
0xKiwi and
terencechain
and removed request for
a team
nisdas
commented
May 21, 2020
Codecov Report
@@ Coverage Diff @@
## v0.12 #5941 +/- ##
==========================================
+ Coverage 59.19% 59.55% +0.36%
==========================================
Files 319 319
Lines 26881 27165 +284
==========================================
+ Hits 15912 16179 +267
- Misses 8786 8789 +3
- Partials 2183 2197 +14 |
0xKiwi
approved these changes
May 22, 2020
nisdas
added a commit
that referenced
this pull request
May 22, 2020
* finally get it working * Update beacon-chain/powchain/service_test.go * Merge refs/heads/v0.12 into eth1Fixes * fix test * Merge branch 'eth1Fixes' of https://github.com/prysmaticlabs/geth-sharding into eth1Fixes * Merge refs/heads/v0.12 into eth1Fixes * Merge refs/heads/v0.12 into eth1Fixes * Merge refs/heads/v0.12 into eth1Fixes * Merge refs/heads/v0.12 into eth1Fixes * Merge refs/heads/v0.12 into eth1Fixes * Merge refs/heads/v0.12 into eth1Fixes * Merge refs/heads/v0.12 into eth1Fixes * Merge refs/heads/v0.12 into eth1Fixes * Merge refs/heads/v0.12 into eth1Fixes * Merge refs/heads/v0.12 into eth1Fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Spec Update to v0.12
What does this PR do? Why is it needed?
This updates to prysm to adhere to follow back distance in whichever
blocks and logs that they request and process. This was initially
an issue with genesis on witti.
Which issues(s) does this PR fix?
Part of #5935 and follows on from this PR in the spec:
ethereum/consensus-specs#1834
Other notes for review
N.A