Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent parent block with same slot #5842

Merged
merged 12 commits into from
May 18, 2020
Merged

Prevent parent block with same slot #5842

merged 12 commits into from
May 18, 2020

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented May 13, 2020

Note: Blocked by new spec test

@terencechain terencechain added the Blocked Blocked by research or external factors label May 13, 2020
@terencechain terencechain requested a review from a team as a code owner May 13, 2020 22:06
@terencechain terencechain self-assigned this May 13, 2020
@prestonvanloon
Copy link
Member

Can you confirm all of the changes from ethereum/consensus-specs#1818 are present in this PR?

v0.11.3 was release in eth2 specs but spec tests have not been updated yet: https://github.com/ethereum/eth2.0-spec-tests

@terencechain
Copy link
Member Author

Can you confirm all of the changes from ethereum/eth2.0-specs#1818 are present in this PR?

confirmed

@prestonvanloon
Copy link
Member

@prestonvanloon prestonvanloon removed the Blocked Blocked by research or external factors label May 18, 2020
@prestonvanloon
Copy link
Member

Could you also bump the badge in the readme? I think this PR brings us compliant to 0.11.3.

@prylabs-bulldozer prylabs-bulldozer bot merged commit c07f160 into master May 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the sec0 branch May 18, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants