Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared/keystore: cleanup #5689

Merged
merged 8 commits into from
Apr 30, 2020
Merged

shared/keystore: cleanup #5689

merged 8 commits into from
Apr 30, 2020

Conversation

farazdagi
Copy link
Contributor

@farazdagi farazdagi commented Apr 30, 2020

What type of PR is this?
Other

What does this PR do? Why is it needed?

Which issues(s) does this PR fix?
N/A

Other notes for review
This PR:

  • makes naming consistent
  • removes unused code
  • fixes incorrect temp data teardown in tests (temp files were removed at the end of the functions, and t.Fatalf() were used in code - so on error teardown never occured, thus making running tests non-idempotent operation)
  • also temp directory used wasn't assuming tests can be run concurrently/sharded

@farazdagi farazdagi self-assigned this Apr 30, 2020
@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #5689 into master will decrease coverage by 17.17%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master   #5689       +/-   ##
==========================================
- Coverage   20.95%   3.78%   -17.18%     
==========================================
  Files         240      73      -167     
  Lines       21453    6824    -14629     
==========================================
- Hits         4495     258     -4237     
+ Misses      16077    6513     -9564     
+ Partials      881      53      -828     

@farazdagi farazdagi marked this pull request as ready for review April 30, 2020 14:16
@farazdagi farazdagi requested a review from a team as a code owner April 30, 2020 14:16
@rauljordan rauljordan merged commit cc07494 into master Apr 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the keystore-cleanup branch April 30, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants