Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated sig verification #5676

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

terencechain
Copy link
Member

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

Remove one duplicated aggregated attestation signature verification. Get back 10ms

Which issues(s) does this PR fix?

Fixes #5670

@terencechain terencechain added Bug Something isn't working Ready For Review A pull request ready for code review labels Apr 29, 2020
@terencechain terencechain requested a review from a team as a code owner April 29, 2020 15:36
@terencechain terencechain self-assigned this Apr 29, 2020
@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #5676 into master will decrease coverage by 48.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #5676       +/-   ##
==========================================
- Coverage   49.64%   1.47%   -48.18%     
==========================================
  Files         239      69      -170     
  Lines       20955    6492    -14463     
==========================================
- Hits        10404      96    -10308     
+ Misses       8764    6387     -2377     
+ Partials     1787       9     -1778     

@prylabs-bulldozer prylabs-bulldozer bot merged commit 05fcb10 into master Apr 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the rm-dup-sig-verifications branch April 29, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

verifyIndexedAttestation duplication in validateAggregatedAndProof
2 participants