Add Debug RPC Service to Prysm #5666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xKiwi
approved these changes
Apr 28, 2020
| name = "go_grpc_gateway_library", | ||
| compilers = [ | ||
| "@io_bazel_rules_go//proto:go_grpc", | ||
| "@grpc_ecosystem_grpc_gateway//protoc-gen-grpc-gateway:go_gen_grpc_gateway", |
There was a problem hiding this comment.
Did you want to add this to the gRPC gateway? it's not automatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
We should have a special
debugRPC service which can conditionally be exposed by Prysm nodes for local development. One such important use-case is the ability to fetch the beacon state from the running node by block root or state root. This PR adds the proto definitions for such service into Prysm. A future PR will implement it and gate it behind a feature flag.