Update protobuf, skylib, rules_go, grpc-gateway dependencies #5657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5657 +/- ##
===========================================
+ Coverage 15.44% 56.06% +40.62%
===========================================
Files 116 312 +196
Lines 9403 25870 +16467
===========================================
+ Hits 1452 14504 +13052
- Misses 7722 9311 +1589
- Partials 229 2055 +1826 |
shayzluf
reviewed
Apr 28, 2020
WORKSPACE
Outdated
| urls = [ | ||
| "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.22.2/rules_go-v0.22.2.tar.gz", | ||
| "https://github.com/bazelbuild/rules_go/releases/download/v0.22.2/rules_go-v0.22.2.tar.gz", | ||
| "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.21.7/rules_go-v0.21.7.tar.gz", |
There was a problem hiding this comment.
why did you decide to downgrade io_bazel_rules_go . i think it was upgraded to support go 1.14
There was a problem hiding this comment.
Oh no! I didn’t mean to downgrade. Nice catch, i’ll Fix tomorrow
rauljordan
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Updates protobuf, skylib, rules_go, grpc-gateway.
Which issues(s) does this PR fix?
Part of #5651
Other notes for review
This PR allows for the requests outlined in #5651 to work if the parameters are properly URL encoded. I'm not marking that issue as "fixed" because this is different behavior from our envoy production implementation of https://api.prylabs.net