-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests depending on configuration flag #5650
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farazdagi
changed the title
Fix test depending on configuration flag
Fix tests depending on configuration flag
Apr 27, 2020
Codecov Report
@@ Coverage Diff @@
## master #5650 +/- ##
==========================================
- Coverage 22.94% 21.08% -1.87%
==========================================
Files 268 179 -89
Lines 23003 16034 -6969
==========================================
- Hits 5279 3381 -1898
+ Misses 16856 12096 -4760
+ Partials 868 557 -311 |
rauljordan
previously approved these changes
Apr 27, 2020
prestonvanloon
previously approved these changes
Apr 27, 2020
farazdagi
added
Ready For Review
A pull request ready for code review
and removed
In Progress
labels
Apr 27, 2020
prestonvanloon
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Fixes #5648
Other notes for review
featureconfig.Init
calls in tests anymore, I've fixed all tests - with one exceptionTestServer_ListBlocks_Pagination
- it is marked as skipped, and I will create a separate issue for itinit()
functions toTestMain()
(there were two such ocurrences)featureconfig
:Please review how it is used, as it will be preferred way to set config params in tests (so suggestions are welcome):