Add Block Batch Limit Flag #5646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
commented
Apr 27, 2020
Codecov Report
@@ Coverage Diff @@
## master #5646 +/- ##
===========================================
- Coverage 53.70% 41.96% -11.74%
===========================================
Files 300 239 -61
Lines 24858 20718 -4140
===========================================
- Hits 13349 8694 -4655
- Misses 9545 10434 +889
+ Partials 1964 1590 -374 |
terencechain
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
It makes our block batch limit configurable and bumps it up to 64 from 32. Given that
nodes can now request and serve large block amounts, it isn't an issue serving larger requests.
Which issues(s) does this PR fix?
Resolves #5587 , it takes care of the final action item specified in the issue.
Other notes for review
We also change all our constants in initial sync to be configurable via the flag for larger block batch requests.