Create Pcli #5644
Merged
Create Pcli #5644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Ready For Review
farazdagi
previously approved these changes
Apr 27, 2020
Co-Authored-By: Victor Farazdagi <[email protected]>
Co-Authored-By: Victor Farazdagi <[email protected]>
shayzluf
reviewed
Apr 27, 2020
shayzluf
reviewed
Apr 27, 2020
shayzluf
reviewed
Apr 27, 2020
tools/pcli/main.go
Outdated
| Destination: &blockPath, | ||
| }, | ||
| &cli.StringFlag{ | ||
| Name: "preStatePath", |
There was a problem hiding this comment.
our cli flags are using dashes usually
Suggested change
| Name: "preStatePath", | |
| Name: "pre-state-path", |
shayzluf
reviewed
Apr 27, 2020
shayzluf
reviewed
Apr 27, 2020
tools/pcli/README.md
Outdated
|
|
||
|
|
||
| *State Transition Flags:* | ||
| --blockPath value Path to block file(ssz) |
There was a problem hiding this comment.
Suggested change
| --blockPath value Path to block file(ssz) | |
| --block-path value Path to block file(ssz) |
shayzluf
reviewed
Apr 27, 2020
shayzluf
reviewed
Apr 27, 2020
tools/pcli/README.md
Outdated
| *State Transition Flags:* | ||
| --blockPath value Path to block file(ssz) | ||
| --preStatePath value Path to pre state file(ssz) | ||
| --expectedPostStatePath value Path to expected post state file(ssz) |
There was a problem hiding this comment.
Suggested change
| --expectedPostStatePath value Path to expected post state file(ssz) | |
| --expected-post-state-path value Path to expected post state file(ssz) |
shayzluf
reviewed
Apr 27, 2020
terencechain
approved these changes
Apr 27, 2020
shayzluf
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This creates a prysm specific cli, through which we can perform all the useful eth2 utilities.
Analogous to zcli,lcli,ncli for the other eth2 clients. This utility will help in debugging any state
root bugs. Currently it just performs manual state transitions.
Which issues(s) does this PR fix?
N.A
Other notes for review
N.A