Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checks prysm.sh args size #5634

Merged
merged 2 commits into from
Apr 26, 2020
Merged

checks prysm.sh args size #5634

merged 2 commits into from
Apr 26, 2020

Conversation

farazdagi
Copy link
Contributor

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

  • checks args size before working with args themselves

Which issues(s) does this PR fix?

Fixes #5633

Other notes for review

@farazdagi farazdagi added Ready For Review A pull request ready for code review OK to merge labels Apr 26, 2020
@farazdagi farazdagi requested a review from a team as a code owner April 26, 2020 21:11
@farazdagi farazdagi self-assigned this Apr 26, 2020
@prylabs-bulldozer prylabs-bulldozer bot merged commit 3782e70 into master Apr 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-prysm-sh-unbounded-bug branch April 26, 2020 21:24
@Gsuslu
Copy link

Gsuslu commented Apr 27, 2020

Works for me. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvanloon prestonvanloon prestonvanloon approved these changes

@rauljordan rauljordan Awaiting requested review from rauljordan

@shayzluf shayzluf Awaiting requested review from shayzluf

Assignees

@farazdagi farazdagi

Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot run prysm.sh with no args to process
3 participants
@farazdagi @Gsuslu @prestonvanloon