GetBlock: Refactor attestation packing #5632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bs/prysm into refactor-attestation-packing
| if err != nil { | ||
| return nil, errors.Wrap(err, "could fetch head state") | ||
| } | ||
| if st.Slot() < slot { |
There was a problem hiding this comment.
I wonder if this can be
SlotsToEpoch(st.Slot()) < SlotsToEpoch(slot)
In other word, having the base state up to epoch boundary slot is sufficient enough
terencechain
approved these changes
Apr 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
We see process slots and hash tree root applied multiple times. This PR reduces the redundant work and should save 50ms to 100ms on block proposals.
Which issues(s) does this PR fix?
N/A -- minor tweak
Other notes for review
I fixed imports in beacon-chain/rpc/validator/server.go on accident.