Use signature for SignedAggregateAttestationAndProof
#5605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5605 +/- ##
==========================================
+ Coverage 12.68% 13.04% +0.35%
==========================================
Files 113 116 +3
Lines 9169 9285 +116
==========================================
+ Hits 1163 1211 +48
- Misses 7803 7865 +62
- Partials 203 209 +6 |
nisdas
previously requested changes
Apr 24, 2020
0xKiwi
reviewed
Apr 24, 2020
| } | ||
| if _, err := bls.SignatureFromBytes(sig); err != nil { | ||
| t.Fatal(err) | ||
| } |
There was a problem hiding this comment.
Can you add a sig verify or something for this?
There was a problem hiding this comment.
This is sufficient. We just want to verify that it's a "valid" BLS signature which was where the regression is. As we previously use signing root instead of signature (different byte lengths)
0xKiwi
previously approved these changes
Apr 24, 2020
|
|
||
| m.validatorClient.EXPECT().DomainData( | ||
| gomock.Any(), // ctx | ||
| gomock.Any(), // epoch |
There was a problem hiding this comment.
Do you know the epoch value? That would be preferred over gomock.Any()
There was a problem hiding this comment.
Good point. Using:
ðpb.DomainRequest{Epoch: 0, Domain: params.BeaconConfig().DomainAggregateAndProof[:]},
prestonvanloon
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5556
Validator forgot to sign over signing root object and included the signing root as the signature