Solve -1 ActivationEpoch in validator logging #5569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xKiwi
changed the title
rauljordan
previously approved these changes
Apr 21, 2020
prestonvanloon
requested changes
Apr 21, 2020
beacon-chain/rpc/validator/status.go
Outdated
| @@ -91,7 +90,9 @@ func (vs *Server) validatorStatus(ctx context.Context, pubKey []byte, headState | |||
| traceutil.AnnotateError(span, err) | |||
| return resp | |||
| } | |||
| resp.ActivationEpoch = int64(val.ActivationEpoch) | |||
| if val.ActivationEpoch != params.BeaconConfig().FarFutureEpoch { | |||
There was a problem hiding this comment.
Please change this back. Far future epoch is the new "zero".
Codecov Report
@@ Coverage Diff @@
## master #5569 +/- ##
===========================================
+ Coverage 19.98% 53.87% +33.88%
===========================================
Files 239 310 +71
Lines 20637 25391 +4754
===========================================
+ Hits 4125 13680 +9555
+ Misses 15718 9730 -5988
- Partials 794 1981 +1187 |
… into val-active-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure entirely what causes this specific code path, but there may be a case where a PENDING validator gets -1 for its ActivationEpoch on its logs. This solves the problem by removing all int64s which would lead to FarFutureEpoch being -1.