-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update prysm.sh to include slasher and sig verify #5543
Conversation
Hello, is it normal that gpg is telling the RSA key "0AE0051D647BA3C1A917AF4072E33E4DF1A5036E" is not public ? I had to do "gpg --recv-keys 0AE0051D647BA3C1A917AF4072E33E4DF1A5036E". If it's normal it may be usefull to ask the key before trying to check the signature or at least display the command the user has to run in order to get the missing key. Best regards. |
Not that is my business but IMO you should have made 2 separate pullRequest for the commit c2bfe24, you are adding two separate functionality in one PR. |
@Yoldark34 Thanks for the feedback. In general, I think that these features are relatively small in scope and shouldn't be much of a burden on reviewers to review in a single PR. With that said, I probably still should have split this into multiple PRs as I have listed 4 key changes. If a reviewer feels strongly about this, I can split it up. |
I don't think it is a good idea for a script to install third party software so, yes, you have to install it yourself @prestonvanloon is it possible to ask Y/N question prior to launch the program without the checks if there is any possible ? just to be sure people are aware of launching unverified program, and also prevent them to launch it if they don't want. |
Sounds like mac has shasum installed by default, we can use With regards to the public key, I think i'll just make it part of the prysm.sh file so it doesn't need to retrieve from a key server, which could be offline or compromised. @Yoldark34, I'll give it a try. If Y/N input is too difficult to do, maybe we can refuse to run an unverified binary unless there is SKIP_PRYSM_VERIFY=1 or something along those lines that requires user input to skip a failed verification. |
…into verify-sig-prysm-sh
with the specific version, as desired. Example: USE_PRYSM_VERSION=v1.0.0-alpha.5 \ | ||
If you must wish to continue running an unverified binary, specific the \ | ||
environment variable PRYSM_ALLOW_UNVERIFIED_BINARIES=1" | ||
exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice thanks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-tested locally, works ok
Key changes: