-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify block sig #5137
Verify block sig #5137
Conversation
…ock_sig # Conflicts: # beacon-chain/core/blocks/block_operations_fuzz_test.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR uses genesis block root, we need to use genesis validator root
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terence Tsao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Codecov Report
@@ Coverage Diff @@
## v0.11 #5137 +/- ##
========================================
Coverage ? 55.25%
========================================
Files ? 283
Lines ? 22569
Branches ? 0
========================================
Hits ? 12470
Misses ? 8337
Partials ? 1762 |
[Part of] #5116
Description
In order to keep slasher detect slashing and not store validator keys we need to validate blocks in beacon chain before adding them to block stream.