Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify block sig #5137

Closed
wants to merge 23 commits into from
Closed

Verify block sig #5137

wants to merge 23 commits into from

Conversation

shayzluf
Copy link
Contributor

[Part of] #5116


Description

In order to keep slasher detect slashing and not store validator keys we need to validate blocks in beacon chain before adding them to block stream.

Copy link
Member

@nisdas nisdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR uses genesis block root, we need to use genesis validator root

beacon-chain/db/kv/blocks.go Outdated Show resolved Hide resolved
beacon-chain/rpc/beacon/blocks.go Outdated Show resolved Hide resolved
Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is necessary, the sync will verify proposer's signature as the very first line of defense, there's no reason for RPC streaming to verify proposer's signature again. See:

Screen Shot 2020-03-19 at 6 30 52 AM

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ shayzluf
❌ Terence Tsao


Terence Tsao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

❗ No coverage uploaded for pull request base (v0.11@3a5b86b). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             v0.11    #5137   +/-   ##
========================================
  Coverage         ?   55.25%           
========================================
  Files            ?      283           
  Lines            ?    22569           
  Branches         ?        0           
========================================
  Hits             ?    12470           
  Misses           ?     8337           
  Partials         ?     1762

@shayzluf shayzluf closed this Mar 23, 2020
@rauljordan rauljordan deleted the veryfy_block_sig branch October 13, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants