Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

double proposal detector #5120

Merged
merged 9 commits into from
Mar 19, 2020
Merged

double proposal detector #5120

merged 9 commits into from
Mar 19, 2020

Conversation

shayzluf
Copy link
Contributor

[Part of] #5116

@shayzluf shayzluf changed the title proposal detector double proposal detector Mar 17, 2020
@shayzluf shayzluf requested review from 0xKiwi and rauljordan March 17, 2020 17:57
@codecov
Copy link

codecov bot commented Mar 17, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@a9f4d1d). Click here to learn what that means.
The diff coverage is 14.81%.

@@           Coverage Diff            @@
##             master   #5120   +/-   ##
========================================
  Coverage          ?   2.67%           
========================================
  Files             ?     217           
  Lines             ?   15467           
  Branches          ?       0           
========================================
  Hits              ?     414           
  Misses            ?   15007           
  Partials          ?      46

rauljordan
rauljordan reviewed Mar 17, 2020
View reviewed changes
slasher/detection/proposals/detector.go Outdated Show resolved Hide resolved
slasher/detection/proposals/detector_test.go Outdated Show resolved Hide resolved
slasher/detection/proposals/detector.go Show resolved Hide resolved
@shayzluf shayzluf mentioned this pull request Mar 18, 2020
Closed
4 tasks
@shayzluf shayzluf requested a review from rauljordan March 18, 2020 06:38
nisdas
nisdas reviewed Mar 19, 2020
View reviewed changes
slasher/detection/proposals/detector.go
defer span.End()
epoch := helpers.SlotToEpoch(incomingBlk.Header.Slot)
//TODO(#5119) remove constand and use input from block header.
//validatorIdx:=blk.Header.ProposerIndex
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? , why is it commented

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still don't have proposer index in the block header

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would like to use stub till we get v0.11 merged

@shayzluf shayzluf merged commit 6fe814c into master Mar 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the detect_double_propose branch March 19, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nisdas nisdas nisdas approved these changes

@0xKiwi 0xKiwi Awaiting requested review from 0xKiwi

@rauljordan rauljordan Awaiting requested review from rauljordan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shayzluf @rauljordan @nisdas