Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows friendly stdin reads for passwords #5010

Conversation

SuburbanDad
Copy link
Contributor

@SuburbanDad SuburbanDad commented Mar 5, 2020

TODO(you): choose "part of" or "resolves" and the associated github issue #.

[Part of|Resolves] #5008


Description

On windows, syscall.Stdin is not an int. This PR changes reads of stdin (currently only keystore passwords) to cast stdin filehandle to int explicitly. This fixes the windows validator build in #4945

Smoke tested for regression with amd64 build

Write why you are making the changes in this pull request

Write a summary of the changes you are making

Link anything that would be helpful or relevant to the reviewers

Target //validator:validator up-to-date:
  bazel-bin/validator/windows_amd64_stripped/validator.exe
INFO: Elapsed time: 173.822s, Critical Path: 59.89s
INFO: 754 processes: 754 processwrapper-sandbox.
INFO: Build completed successfully, 783 total actions

Copy link
Contributor

@shayzluf shayzluf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plese run goimports -w .

@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #5010 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5010   +/-   ##
=======================================
  Coverage   43.10%   43.10%           
=======================================
  Files         264      264           
  Lines       20331    20331           
=======================================
  Hits         8763     8763           
  Misses      10052    10052           
  Partials     1516     1516           

Copy link
Contributor

@shayzluf shayzluf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prylabs-bulldozer prylabs-bulldozer bot merged commit 5961aaf into prysmaticlabs:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants