Use New State Type in Prysm's Runtime #4614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
commented
Jan 22, 2020
beacon-chain/state/setters.go
Outdated
| // at a specific index to a new value. | ||
| func (b *BeaconState) UpdateBlockRootAtIndex(idx uint64, blockRoot [32]byte) error { | ||
| if len(b.state.BlockRoots) <= int(idx) { | ||
| return errors.Errorf("invalid index provided %d", idx) |
rauljordan
commented
Jan 22, 2020
| "github.com/prysmaticlabs/prysm/shared/params" | ||
| "go.opencensus.io/trace" | ||
| ) | ||
|
|
||
| // New gets called at the beginning of process epoch cycle to return | ||
| // pre computed instances of validators attesting records and total | ||
| // balances attested in an epoch. | ||
| func New(ctx context.Context, state *pb.BeaconState) ([]*Validator, *Balance) { | ||
| func New(ctx context.Context, state *stateTrie.BeaconState) ([]*Validator, *Balance) { |
There was a problem hiding this comment.
Make this take in validators as an argument
| func ProcessRewardsAndPenaltiesPrecompute( | ||
| state *stateTrie.BeaconState, | ||
| bp *Balance, | ||
| vp []*Validator, |
There was a problem hiding this comment.
Take in validators and balances as arguments here
| "github.com/prysmaticlabs/prysm/shared/mathutil" | ||
| "github.com/prysmaticlabs/prysm/shared/params" | ||
| ) | ||
|
|
||
| // ProcessSlashingsPrecompute processes the slashed validators during epoch processing. | ||
| // This is an optimized version by passing in precomputed total epoch balances. | ||
| func ProcessSlashingsPrecompute(state *pb.BeaconState, p *Balance) *pb.BeaconState { | ||
| func ProcessSlashingsPrecompute(state *stateTrie.BeaconState, p *Balance) error { |
There was a problem hiding this comment.
Take in validators as an argument here
beacon-chain/core/exit/validation.go
Outdated
| @@ -17,15 +17,16 @@ import ( | |||
|
|
|||
| // ValidateVoluntaryExit validates the voluntary exit. | |||
| // If it is invalid for some reason an error, if valid it will return no error. | |||
| func ValidateVoluntaryExit(state *pb.BeaconState, genesisTime time.Time, signed *ethpb.SignedVoluntaryExit) error { | |||
| func ValidateVoluntaryExit(state *stateTrie.BeaconState, genesisTime time.Time, signed *ethpb.SignedVoluntaryExit) error { | |||
There was a problem hiding this comment.
Take in validators as an argument
| @@ -56,7 +57,7 @@ func IsSlashableValidator(validator *ethpb.Validator, epoch uint64) bool { | |||
| // Return the sequence of active validator indices at ``epoch``. | |||
| // """ | |||
| // return [ValidatorIndex(i) for i, v in enumerate(state.validators) if is_active_validator(v, epoch)] | |||
| func ActiveValidatorIndices(state *pb.BeaconState, epoch uint64) ([]uint64, error) { | |||
| func ActiveValidatorIndices(state *stateTrie.BeaconState, epoch uint64) ([]uint64, error) { | |||
There was a problem hiding this comment.
Take in list of validators as an index instead
* compute on read * fix up eth1 data votes * looking into slashings bug introduced in core/ * able to advance more slots * add logging * can now sync with testnet yay * remove the leaves algorithm and other merkle imports * expose initialize unsafe funcs * Update beacon-chain/db/kv/state.go * lint Co-authored-by: Raul Jordan <[email protected]>
* map optimization * more optimizations * use a custom hasher * comment * block operations optimizations * Update beacon-chain/state/types.go Co-Authored-By: Raul Jordan <[email protected]> * fixed up various operations to use the validator index map access Co-authored-by: Raul Jordan <[email protected]>
* parallelize shuffling * clean up * lint * fix build * use callback to read from registry * fix array roots and size map * new improvements * reduce hash allocs * improved shuffling * terence's review * use different method * raul's comment * new array roots * remove clone in pre-compute * Update beacon-chain/state/types.go Co-Authored-By: Raul Jordan <[email protected]> * raul's review * lint * fix build issues * fix visibility Co-authored-by: Raul Jordan <[email protected]>
|
Closing in favor of #4646 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2011 and is a follow-up to #4602
Description
Write why you are making the changes in this pull request
This PR utilizes the new state type defined in #4602 and integrates it into the Prysm runtime. This is a major PR that modifies much of our core code and needs to be executed carefully before merge.
Link anything that would be helpful or relevant to the reviewers
Here is what has been done so far:
*state.BeaconStatetype instead of the protobuf definition for all state related functionsHeadStatein theblockchainservice and modify the head fetcher interface to return this typeIn terms of modifying our
core/package, here's what has been done:beacon-chain/state/getters.goandsetters.gosuch asstate.AppendValidatorsorstate.NumValidators()to prevent giant cloning ofstate.Validators()in a bunch of core functionsstate.UpdateCurrentEpochAttestationsAtIndexsetters which modify a single element of a field in the new beacon state typestate.Validators()in the core state transition function and instead try to pass in the same value downstream to the helper functions within the state transition funcerrorinstead of returning state since we are no longer doing the pattern ofstate = ProcessAttestations(state, block)with this new type, but insteadif err := ProcessAttestations(state, block); err != nilas an alternativecore/state/package has yet to be touched and has yet to use this new typeIn terms of whats left in the repo:
Runtime