Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Peer Limiter #4133

Closed
wants to merge 6 commits into from
Closed

Add Peer Limiter #4133

wants to merge 6 commits into from

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Nov 27, 2019

This modifies libp2p's internal swarm to prevent new connections from being formed if that would exceed our peer limit

@nisdas nisdas added Networking P2P related items Ready For Review labels Nov 27, 2019
importpath = "github.com/libp2p/go-libp2p",
remote = "https://github.com/nisdas/go-libp2p",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this branch is 500+ commits behind master, can we submit a PR upstream to enable peer limiting?

@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #4133 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4133   +/-   ##
=======================================
  Coverage   28.09%   28.09%           
=======================================
  Files         143      143           
  Lines        9083     9083           
=======================================
  Hits         2552     2552           
  Misses       6124     6124           
  Partials      407      407

@nisdas nisdas mentioned this pull request Nov 28, 2019
2 tasks
@prestonvanloon
Copy link
Member

Upstream PR: libp2p/go-libp2p-swarm#146

@prestonvanloon prestonvanloon added the Blocked Blocked by research or external factors label Nov 28, 2019
@nisdas
Copy link
Member Author

nisdas commented Dec 4, 2019

Closing this in favour of #4110

@nisdas nisdas closed this Dec 4, 2019
@nisdas nisdas deleted the addPeerLimiter branch December 4, 2019 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Blocked by research or external factors Networking P2P related items
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants