Implement Attester Slashing Handler in Sync #3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
requested review from
prestonvanloon,
terencechain,
0xKiwi,
rauljordan and
shayzluf
Codecov Report
@@ Coverage Diff @@
## master #3260 +/- ##
=======================================
Coverage 51.12% 51.12%
=======================================
Files 153 153
Lines 10797 10797
=======================================
Hits 5520 5520
Misses 4404 4404
Partials 873 873 |
shayzluf
reviewed
Aug 21, 2019
Co-Authored-By: shayzluf <[email protected]>
| } | ||
|
|
||
| if err := blocks.VerifyAttesterSlashing(state, slashing); err != nil { | ||
| log.WithError(err).Warn("Received invalid attester slashing") |
There was a problem hiding this comment.
Where/when do we blacklist failed attester slashing?
Say we got to this point, the attester slashing failed to process, we error'ed out, and the same attester slashing comes again
… into attesterSlashingHandler
…clabs/geth-sharding into attesterSlashingHandler
… into attesterSlashingHandler
… into attesterSlashingHandler
terencechain
approved these changes
Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3147