Lock Down the ReceiveBlock Function #2387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2387 +/- ##
==========================================
- Coverage 67.51% 67.27% -0.24%
==========================================
Files 119 119
Lines 9711 9507 -204
==========================================
- Hits 6556 6396 -160
+ Misses 2420 2408 -12
+ Partials 735 703 -32 |
…m into lock-block-processing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1586. We should add a mutex to processing blocks so we only process one at a time no matter what. The receive block function is main entrypoint for processing both in p2p and RPC block proposals, and this mutex will eliminate much of the pain we've been seeing lately.