Enable Ancestor Cache By Default #2358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
requested review from
terencechain,
prestonvanloon,
nisdas,
0xKiwi and
shayzluf
Codecov Report
@@ Coverage Diff @@
## master #2358 +/- ##
==========================================
+ Coverage 68.2% 68.34% +0.14%
==========================================
Files 117 117
Lines 9230 9222 -8
==========================================
+ Hits 6295 6303 +8
+ Misses 2254 2243 -11
+ Partials 681 676 -5 |
prestonvanloon
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #1586
Description
Write why you are making the changes in this pull request
Our block ancestor cache has been working well and offers significant improvements in fork choice. However, it is still hidden behind a feature flag.
Write a summary of the changes you are making
This PR makes the ancestor cache enabled the default behavior and removes the feature flag for it.