Loop Once Over state.LatestAttestations in Epoch Processing #2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
requested review from
terencechain,
prestonvanloon,
0xKiwi,
nisdas and
shayzluf
rauljordan
added
Enhancement
Codecov Report
@@ Coverage Diff @@
## master #2342 +/- ##
==========================================
- Coverage 68.64% 68.39% -0.25%
==========================================
Files 117 117
Lines 9224 9199 -25
==========================================
- Hits 6332 6292 -40
- Misses 2218 2234 +16
+ Partials 674 673 -1 |
terencechain
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1586
Description
Write why you are making the changes in this pull request
Hi all, currently we have a lot of expensive operations that run a for loop over the state's latest attestations repeatedly, leading to some situations that often have quadratic or cubic time complexity. Many of the initial parts of epoch processing deal with sorting out current/prev epoch information from this list of state latest attestations, which could all be done in a single for loop.
Write a summary of the changes you are making
This PR combines all the functions that require extracting information from state.LatestAttestations to minimize the number of times epoch processing has to loop over that array, leading to performance gains.