Prevent Canceling Goroutines in Validator Client #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
validator/client/runner.go
Outdated
| @@ -62,7 +62,7 @@ func run(ctx context.Context, v Validator) { | |||
| return // Exit if context is canceled. | |||
| case slot := <-v.NextSlot(): | |||
| span.AddAttributes(trace.Int64Attribute("slot", int64(slot))) | |||
| slotCtx, cancel := context.WithDeadline(ctx, v.SlotDeadline(slot)) | |||
| slotCtx, cancel := context.WithDeadline(context.Background(), v.SlotDeadline(slot)) | |||
terencechain
previously approved these changes
Apr 21, 2019
prestonvanloon
previously approved these changes
Apr 21, 2019
prestonvanloon
dismissed stale reviews from terencechain and themself
via
a1e98a7
Codecov Report
@@ Coverage Diff @@
## master #2324 +/- ##
==========================================
- Coverage 68.78% 68.77% -0.01%
==========================================
Files 117 117
Lines 9193 9192 -1
==========================================
- Hits 6323 6322 -1
Misses 2188 2188
Partials 682 682 |
prestonvanloon
approved these changes
Apr 21, 2019
terencechain
pushed a commit
that referenced
this pull request
Apr 22, 2019
* do not cancel assignments goroutines * exclude rule * disable lostcancel for now
terencechain
pushed a commit
that referenced
this pull request
Apr 22, 2019
* do not cancel assignments goroutines * exclude rule * disable lostcancel for now
prestonvanloon
pushed a commit
that referenced
this pull request
Apr 23, 2019
* update attestation related protos * use root for hash32 * fixed a few typos * review comments * update historical batch, deposit and blk header fields * Add nogo to introduce built time linting (#2317) * Add nogo and fix lint issues * Run gazelle * better gazelle * ignore external struct tags * Exclude all third party code from unsafeptr (#2321) * Fix Assingments Bug (#2320) * fix * fix tests * Add feature flag to toggle gossip sub in p2p (#2322) * add feature flag to enable gossip sub in p2p * invert the enable/disable logic * add the flag in k8s and fix tests * gazellle * return empty config if nil * Prevent Canceling Goroutines in Validator Client (#2324) * do not cancel assignments goroutines * exclude rule * disable lostcancel for now * Fix Pending Attestations RPC Call (#2304) * pending atts * use proposal slot * attestation inclusion fix * lint * advance state transitions * gazelle * lint tests pass * Do Not Update Validator Registry on Nil Block (#2326) * no registry update if block is nil * regression test * lint * Ensure Block Processing Failures Return an Error (#2325) * ensure block failed processing returns an error * fixed test * test assertion corrected * comments * fix tests * imports * rebase * add spec badge. Thanks to ChainSafe/lodestar#166 for the idea :) * Update Crosslink Protobuf Fields (#2313) * rebase * rebase * rebase * Prevent Canceling Goroutines in Validator Client (#2324) * do not cancel assignments goroutines * exclude rule * disable lostcancel for now * starting proposer slashing * starting attester slashing * revert gen file * Update types.pb.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2317
Description
Write why you are making the changes in this pull request
We were canceling the context to each of the goroutines in the block of code in validator/runner.go:
Write a summary of the changes you are making
This PR removes the cancel call.