Revert Usage of ssz.TreeHash Across Repo #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
added
Enhancement
Codecov Report
@@ Coverage Diff @@
## master #1711 +/- ##
======================================
Coverage 74.2% 74.2%
======================================
Files 101 101
Lines 7884 7884
======================================
Hits 5850 5850
Misses 1526 1526
Partials 508 508 |
terencechain
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1565
Description
Write why you are making the changes in this pull request
Given our monolithic state decision for our testnet in addition to not having an implemented caching layer for tree hashing, tree hashing becomes an unnecessary bottleneck in our beacon chain processing, increasing the time to process blocks and fetch state by over 10 times.
Write a summary of the changes you are making
This PR simply replaces it with hashutil.HashBeaconBlock which reverts back to the old hash function we've been using instead of ssz.TreeHash.