Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Note for Leap Sec in Block Validity Condition #1622

Merged
merged 8 commits into from
Feb 17, 2019
Merged

Add a Note for Leap Sec in Block Validity Condition #1622

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a5d1432
fixed epoch_processing
terencechain Feb 6, 2019
f46ad60
Merge branch 'master' of github.com:prysmaticlabs/prysm
terencechain Feb 17, 2019
17a5592
added leap sec description
terencechain Feb 17, 2019
1b4956a
revert
terencechain Feb 17, 2019
b2bfaed
fixed epoch_processing
terencechain Feb 6, 2019
9e695f0
added leap sec description
terencechain Feb 17, 2019
1feae44
revert
terencechain Feb 17, 2019
95cab5e
Merge branch 'add-leap-secs-descriptions' of github.com:prysmaticlabs…
terencechain Feb 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions beacon-chain/core/blocks/validity_conditions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,10 @@ func IsValidBlock(
}

// Pre-Processing Condition 4:
// The node's local time is greater than or equal to
// state.genesis_time + (block.slot-GENESIS_SLOT)* SLOT_DURATION.
// The node's local Unix time is greater than or equal to
// state.genesis_time + (block.slot-GENESIS_SLOT) * SLOT_DURATION.
// (Note that leap seconds mean that slots will occasionally last SLOT_DURATION + 1 or
// SLOT_DURATION - 1 seconds, possibly several times a year.)
if !IsSlotValid(block.Slot, genesisTime) {
return fmt.Errorf("slot of block is too high: %d", block.Slot)
}
Expand Down