Fetch Initial Assignments at Genesis Slot Post ChainStart #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1574 +/- ##
=========================================
Coverage ? 71.88%
=========================================
Files ? 98
Lines ? 6673
Branches ? 0
=========================================
Hits ? 4797
Misses ? 1468
Partials ? 408 |
| @@ -105,8 +105,8 @@ func (v *validator) UpdateAssignments(ctx context.Context, slot uint64) error { | |||
| span, ctx := opentracing.StartSpanFromContext(ctx, "validator.UpdateAssignments") | |||
| defer span.Finish() | |||
|
|
|||
| if slot%params.BeaconConfig().EpochLength != 0 { | |||
| // Do nothing if not epoch start. | |||
| if slot%params.BeaconConfig().EpochLength != 0 && v.assignment != nil { | |||
There was a problem hiding this comment.
This should be ||, why wait until an epoch start if you don't have your assignments yet?
There was a problem hiding this comment.
Resolved offline, this is the exit condition and I misunderstood
prestonvanloon
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #1565
Description
Write why you are making the changes in this pull request
Our current validator code does not fetch initial assignments soon after the chain has started to begin its responsibilities. We need this in order for validators to work correctly.
Write a summary of the changes you are making
This PR modifies the update assignments function in the validator client to check to only perform an update if either it is an epoch start or is assignments are nil.