Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Change Max Payload Size (#14692)" #14716

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Revert "Change Max Payload Size (#14692)" #14716

merged 1 commit into from
Dec 12, 2024

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Dec 12, 2024 •
edited by prestonvanloon
Loading

What type of PR is this?

Revert Feature

What does this PR do? Why is it needed?

This reverts commit df81fa3. #14692

Which issues(s) does this PR fix?

N.A

Other notes for review

Acknowledgements

  • I have read CONTRIBUTING.md.
  • I have made an appropriate entry to CHANGELOG.md.
  • I have added a description to this PR with sufficient context for reviewers to understand this PR.

@nisdas nisdas added the Blocked Blocked by research or external factors label Dec 12, 2024
@prestonvanloon prestonvanloon marked this pull request as ready for review December 12, 2024 15:09
@prestonvanloon prestonvanloon requested a review from a team as a code owner December 12, 2024 15:09
@prestonvanloon prestonvanloon removed the Blocked Blocked by research or external factors label Dec 12, 2024
@prestonvanloon
Copy link
Member

ACD 167 (ethereum/pm#1211) consensus is that we should not change these config values outside of a hardfork.

@potuz
Copy link
Contributor

potuz commented Dec 12, 2024 •
edited
Loading

Is there a button to disapprove? :) this was really a successful filibuster, it's such a no brainer

@prestonvanloon
Copy link
Member

Is there a button to disapprove? :) this was really a successful filibuster, it's such a no brainer

Your disapproval is noted. I was in favor of updating the config ASAP too. 😩

@prestonvanloon prestonvanloon added this pull request to the merge queue Dec 12, 2024
Merged via the queue into develop with commit ac1717f Dec 12, 2024
15 checks passed
@prestonvanloon prestonvanloon deleted the revertUncompressedIncrease branch December 12, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvanloon prestonvanloon prestonvanloon approved these changes

@nalepae nalepae Awaiting requested review from nalepae nalepae is a code owner automatically assigned from prysmaticlabs/core-team

@saolyn saolyn Awaiting requested review from saolyn saolyn is a code owner automatically assigned from prysmaticlabs/core-team

@potuz potuz Awaiting requested review from potuz potuz is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nisdas @prestonvanloon @potuz