Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix --backfill-oldest-slot flag handling #14584

Merged
merged 2 commits into from
Oct 28, 2024
Merged

fix --backfill-oldest-slot flag handling #14584

merged 2 commits into from
Oct 28, 2024

Conversation

kasey
Copy link
Contributor

@kasey kasey commented Oct 28, 2024 •
edited
Loading

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

This fixes an embarassing bug where the code handling --backfill-oldest-slot was pulling a value from the wrong flag. Big thanks to @xinzhongyoumeng for an incredibly helpful bug report pointing to the exact line of code that was incorrect.

Which issues(s) does this PR fix?

Fixes #14563

Other notes for review

Acknowledgements

  • I have read CONTRIBUTING.md.
  • I have made an appropriate entry to CHANGELOG.md.
  • I have added a description to this PR with sufficient context for reviewers to understand this PR.

@kasey kasey requested a review from a team as a code owner October 28, 2024 15:35
@kasey kasey enabled auto-merge October 28, 2024 15:38
@kasey kasey added this pull request to the merge queue Oct 28, 2024
Merged via the queue into develop with commit 97c8adb Oct 28, 2024
18 checks passed
@kasey kasey deleted the fix-14563 branch October 28, 2024 16:06
@prestonvanloon prestonvanloon mentioned this pull request Oct 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvanloon prestonvanloon prestonvanloon approved these changes

@nisdas nisdas nisdas approved these changes

@nalepae nalepae Awaiting requested review from nalepae nalepae is a code owner automatically assigned from prysmaticlabs/core-team

@saolyn saolyn Awaiting requested review from saolyn saolyn is a code owner automatically assigned from prysmaticlabs/core-team

@rkapka rkapka Awaiting requested review from rkapka rkapka is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the param blob-retention-epochs set failed
3 participants
@kasey @prestonvanloon @nisdas