recover from panics when writing the event stream #14545
Merged
+16
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
previously approved these changes
Oct 16, 2024
prestonvanloon
approved these changes
Oct 16, 2024
prestonvanloon
pushed a commit
that referenced
this pull request
Oct 16, 2024
* recover from panics when writing the event stream --------- Co-authored-by: Kasey Kirkham <[email protected]> (cherry picked from commit 1086bdf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
There is a panic race condition that seems to involve sudden disconnects from a backlogged stream events queue. This PR adds a recover() call as a band-aid to prevent the node crashing when that condition is triggered. Another PR will attempt to address the root cause of the panic.
Acknowledgements