Share resources between empty and full nodes #14517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
requested review from
prestonvanloon,
saolyn and
terencechain
and removed request for
a team
terencechain
reviewed
Oct 9, 2024
| weight uint64 // weight of this node: the total balance including children | ||
| bestDescendant *Node // bestDescendant node of this node. | ||
| withheld bool // whether the builder sent a withheld message for this payload | ||
| full bool // wether the node represents full or empty forkchoice node |
There was a problem hiding this comment.
Suggested change
| full bool // wether the node represents full or empty forkchoice node | |
| full bool // whether the node represents full or empty forkchoice node |
terencechain
reviewed
Oct 9, 2024
| } | ||
| return primitives.PAYLOAD_PRESENT | ||
| return primitives.PAYLOAD_ABSENT |
There was a problem hiding this comment.
Shouldn't this be PAYLOAD_WITHHELD? if not, where is withheld...
There was a problem hiding this comment.
I removed withheld in this iteration, adjusting for the minimal Francesco's forkchoice.
potuz
force-pushed
the
shared_nodes
branch
2 times, most recently
from
d19500b
to
d89c046
Compare
potuz
force-pushed
the
epbs
branch
3 times, most recently
from
468ba82
to
40ad265
Compare
- Share a block structure withing the forkchoice node. The surrounding envelope contains information about the payload presence and the children links, the inner structure contains the usual FFG and parent links. - Reworked setOptimistictoInvalid - Changed the PTC vote logic to have validity handled outside of forkchoice and have forkchoice only keep the total count of votes.
potuz
force-pushed
the
shared_nodes
branch
2 times, most recently
from
f28a5e2
to
4088ed6
Compare
terencechain
approved these changes
Oct 31, 2024
potuz
added a commit
that referenced
this pull request
Nov 1, 2024
* Share resources between empty and full nodes - Share a block structure withing the forkchoice node. The surrounding envelope contains information about the payload presence and the children links, the inner structure contains the usual FFG and parent links. - Reworked setOptimistictoInvalid - Changed the PTC vote logic to have validity handled outside of forkchoice and have forkchoice only keep the total count of votes. * Fix tests * gazelle * Update head twice pre-epbs * only upadte best descendants without computing head * skip forkchoice tests * fix some blockchain tests * Nil optimistic sync fix * only count weight of empty nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.