Fix partial withdrawals #14509
Merged
Fix partial withdrawals #14509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
force-pushed
the
fix-partial-withdrawals
branch
from
4821c34
to
82f8391
Compare
james-prysm
previously approved these changes
Oct 7, 2024
3 tasks
terencechain
force-pushed
the
fix-partial-withdrawals
branch
from
82f8391
to
dcc33d0
Compare
james-prysm
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #14430 for spec tests
Bug description: https://hackmd.io/@ttsao/S13TVqkA0
Fix: reference: ethereum/consensus-specs#3943
The bug in Electra occurs during the processing of partial withdrawals. When a pending partial withdrawal is skipped due to insufficient effective or excess balance, an offset is created because the
partial_withdrawals_countdoesn't account for the skipped withdrawal. This leads to the same withdrawal being processed twice, as skipped withdrawals aren't properly counted. The solution is to incrementpartial_withdrawals_counteven for skipped withdrawals to ensure accurate pruning ofpending_partial_withdrawals.