Add GetPTCVote helpers #14420
Merged
Add GetPTCVote helpers #14420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
requested review from
rkapka,
nisdas and
james-prysm
and removed request for
a team
potuz
force-pushed
the
forkchoice_payload
branch
from
904aaf0
to
c2faea7
Compare
jihoonsong
approved these changes
Sep 5, 2024
terencechain
reviewed
Sep 5, 2024
| timestamp uint64 // The timestamp when the node was inserted. | ||
| ptcVote []primitives.PTCStatus // tracks the Payload Timeliness Committee (PTC) votes for the node | ||
| withheld bool // whether the builder sent a withheld message for this payload |
There was a problem hiding this comment.
withheld is not set today, but I take it you haven't implemented it yet
terencechain
approved these changes
Sep 5, 2024
potuz
added a commit
that referenced
this pull request
Sep 13, 2024
potuz
added a commit
that referenced
this pull request
Sep 18, 2024
potuz
added a commit
that referenced
this pull request
Sep 26, 2024
potuz
added a commit
that referenced
this pull request
Oct 7, 2024
potuz
added a commit
that referenced
this pull request
Oct 14, 2024
potuz
added a commit
that referenced
this pull request
Oct 16, 2024
potuz
added a commit
that referenced
this pull request
Oct 22, 2024
potuz
added a commit
that referenced
this pull request
Oct 28, 2024
potuz
added a commit
that referenced
this pull request
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
withheldboolean to forkchoice nodes to signal that we have synced succesfully aPAYLOAD_WITHHELDmessage