Hardcoded genesisValidator Root instead of computing #14392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redidacove
force-pushed
the
UseValidatorRoot
branch
from
538c138
to
8063971
Compare
Redidacove
changed the title
Redidacove
changed the title
Redidacove
commented
Aug 28, 2024
| @@ -19,7 +19,6 @@ func TestUpgradeToBellatrix(t *testing.T) { | |||
| require.NoError(t, err) | |||
|
|
|||
| require.Equal(t, preForkState.GenesisTime(), mSt.GenesisTime()) | |||
| require.DeepSSZEqual(t, preForkState.GenesisValidatorsRoot(), mSt.GenesisValidatorsRoot()) | |||
There was a problem hiding this comment.
Don't need this because GenesisValidator fn is removed
Redidacove
commented
Aug 28, 2024
| @@ -19,14 +19,6 @@ func (b *BeaconState) GenesisTime() uint64 { | |||
| return b.genesisTime | |||
| } | |||
|
|
|||
| // GenesisValidatorsRoot of the beacon state. | |||
| func (b *BeaconState) GenesisValidatorsRoot() []byte { | |||
| b.lock.RLock() | |||
There was a problem hiding this comment.
Removed this one
Redidacove
force-pushed
the
UseValidatorRoot
branch
from
1b500a2
to
a77e32b
Compare
nisdas
requested changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed ?
Replaced hardcoded value everywhere where fn was called to compute it from state calling st.GenesisValidatorRoot()
Which issues(s) does this PR fix ?
Fixes
Issue #14364
Other notes for review
I have removed st.GenesisValidator() function and replaced it with hardcoded value whenever its needed in this PR