Add ePBS fork schedule to config #14383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihoonsong
requested review from
rauljordan,
prestonvanloon and
rkapka
and removed request for
a team
potuz
approved these changes
Aug 26, 2024
jihoonsong
force-pushed
the
config-fork-schedule-epbs
branch
3 times, most recently
from
4b37588
to
5691fbc
Compare
jihoonsong
force-pushed
the
config-fork-schedule-epbs
branch
from
5691fbc
to
355a199
Compare
potuz
reviewed
Aug 27, 2024
Comment on lines
-33
to
+34
| e := fsched[i].Epoch | ||
| ad, err := dc.forEpoch(e) | ||
| n := fsched[i].Name | ||
| ad, err := dc.forName(n) |
There was a problem hiding this comment.
Using epoch to query fork domain is based an assumption that no two updates have a same epoch. While it's a solid one, it doesn't hold when more than two updates are underway like current case — Electra and ePBS. I think assuming there will be no duplicate name is slightly better than epoch.
potuz
pushed a commit
that referenced
this pull request
Aug 29, 2024
potuz
added a commit
that referenced
this pull request
Sep 13, 2024
potuz
added a commit
that referenced
this pull request
Sep 18, 2024
potuz
added a commit
that referenced
this pull request
Sep 26, 2024
potuz
added a commit
that referenced
this pull request
Oct 7, 2024
potuz
added a commit
that referenced
this pull request
Oct 14, 2024
potuz
added a commit
that referenced
this pull request
Oct 16, 2024
potuz
added a commit
that referenced
this pull request
Oct 22, 2024
potuz
added a commit
that referenced
this pull request
Oct 28, 2024
potuz
added a commit
that referenced
this pull request
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This PR adds ePBS fork schedule to config. I guess it was omitted as Electra fork epoch is not defined yet, making both
cfg.ElectraForkEpochandcfg.EPBSForkEpochhavemath.MaxUint64inHoleskyConfigandSepoliaConfigafter adding ePBS fork. If it ought to be added later, please feel free to close this PR.