Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce Capella and Deneb full-node.md lc changes #14376

Merged
merged 43 commits into from
Sep 6, 2024
Merged

feat: introduce Capella and Deneb full-node.md lc changes #14376

merged 43 commits into from
Sep 6, 2024

Conversation

rupam-04
Copy link
Contributor

@rupam-04 rupam-04 commented Aug 22, 2024 •
edited
Loading

What type of PR is this?

Feature

What does this PR do? Why is it needed?

This PR introduces corresponding light client full-node changes from Capella and Deneb

Which issues(s) does this PR fix?

Partially addresses 2nd checkpoint of #12991

rkapka
rkapka requested changes Aug 23, 2024
View reviewed changes
api/server/structs/endpoints_lightclient.go Outdated Show resolved Hide resolved
api/server/structs/endpoints_lightclient.go Outdated Show resolved Hide resolved
beacon-chain/rpc/eth/light-client/handlers.go Outdated Show resolved Hide resolved
beacon-chain/rpc/eth/light-client/helpers.go Outdated Show resolved Hide resolved
beacon-chain/rpc/eth/light-client/helpers.go Outdated Show resolved Hide resolved
beacon-chain/rpc/eth/light-client/helpers.go Outdated Show resolved Hide resolved
beacon-chain/rpc/eth/light-client/helpers.go Outdated Show resolved Hide resolved
rkapka
rkapka reviewed Aug 26, 2024
View reviewed changes
beacon-chain/rpc/eth/light-client/helpers.go Outdated Show resolved Hide resolved
beacon-chain/rpc/eth/light-client/helpers.go Outdated Show resolved Hide resolved
beacon-chain/rpc/eth/light-client/helpers.go Outdated Show resolved Hide resolved
beacon-chain/rpc/eth/light-client/helpers.go Outdated Show resolved Hide resolved
beacon-chain/rpc/eth/light-client/handlers.go Outdated Show resolved Hide resolved
beacon-chain/rpc/eth/light-client/handlers.go Outdated Show resolved Hide resolved
beacon-chain/rpc/eth/light-client/handlers.go Outdated Show resolved Hide resolved
rkapka
rkapka reviewed Aug 29, 2024
View reviewed changes
beacon-chain/rpc/eth/light-client/helpers.go Outdated Show resolved Hide resolved
beacon-chain/rpc/eth/light-client/helpers.go Outdated Show resolved Hide resolved
beacon-chain/rpc/eth/light-client/helpers.go Outdated Show resolved Hide resolved
beacon-chain/rpc/eth/light-client/helpers.go Outdated Show resolved Hide resolved
rupam-04 and others added 14 commits August 29, 2024 22:36
@Inspector-Butters
Copy link
Contributor

@rkapka all comments are resolved. I can't mark them as resolved apparently. @rupam-04 please mark them as resolved.

@rupam-04 rupam-04 marked this pull request as ready for review September 4, 2024 20:44
@rupam-04 rupam-04 requested a review from a team as a code owner September 4, 2024 20:44
rkapka
rkapka reviewed Sep 5, 2024
View reviewed changes
api/server/structs/conversions_lightclient.go Outdated Show resolved Hide resolved
beacon-chain/core/light-client/lightclient.go Show resolved Hide resolved
beacon-chain/core/light-client/lightclient.go Show resolved Hide resolved
beacon-chain/core/light-client/lightclient.go Outdated Show resolved Hide resolved
beacon-chain/rpc/eth/light-client/helpers.go Outdated Show resolved Hide resolved
beacon-chain/rpc/eth/light-client/helpers.go Outdated Show resolved Hide resolved
@rkapka rkapka added this pull request to the merge queue Sep 6, 2024
Merged via the queue into prysmaticlabs:develop with commit eec3b0b Sep 6, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Inspector-Butters Inspector-Butters Inspector-Butters left review comments

@rkapka rkapka rkapka approved these changes

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon prestonvanloon is a code owner automatically assigned from prysmaticlabs/core-team

@terencechain terencechain Awaiting requested review from terencechain terencechain is a code owner automatically assigned from prysmaticlabs/core-team

@nisdas nisdas Awaiting requested review from nisdas nisdas is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rupam-04 @Inspector-Butters @rkapka