Enable validator client to sign execution payload envelope #14346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
requested review from
nalepae,
saolyn and
james-prysm
and removed request for
a team
| if err != nil { | ||
| return nil, errors.Wrap(err, "could not get key manager") | ||
| } | ||
| sig, err := m.Sign(ctx, signReq) |
There was a problem hiding this comment.
Had a question, Is there any scenario where m.sign() might take longer to respond or become unresponsive? If yes would adding a timeout to context handle that scenario?
There was a problem hiding this comment.
Using a local signer is fast, so there's minimal risk of unresponsiveness. However, when using a remote signer, unresponsiveness could occur, and adding a timeout might be a good idea. That said, retrying wouldn't make much sense in this context because we would miss the slot anyway. I prefer not to overcomplicate this right now, but we can revisit this later as part of a more general issue and track it accordingly.
terencechain
force-pushed
the
sign-payload
branch
from
4819974
to
eb4a852
Compare
jihoonsong
reviewed
Aug 15, 2024
Co-authored-by: JihoonSong <[email protected]>
jihoonsong
approved these changes
Aug 15, 2024
potuz
approved these changes
Aug 15, 2024
potuz
pushed a commit
that referenced
this pull request
Aug 29, 2024
* Enable validator client to sign execution payload envelope * Update comment Co-authored-by: JihoonSong <[email protected]> --------- Co-authored-by: JihoonSong <[email protected]>
potuz
pushed a commit
that referenced
this pull request
Sep 13, 2024
* Enable validator client to sign execution payload envelope * Update comment Co-authored-by: JihoonSong <[email protected]> --------- Co-authored-by: JihoonSong <[email protected]>
potuz
pushed a commit
that referenced
this pull request
Sep 18, 2024
* Enable validator client to sign execution payload envelope * Update comment Co-authored-by: JihoonSong <[email protected]> --------- Co-authored-by: JihoonSong <[email protected]>
potuz
pushed a commit
that referenced
this pull request
Sep 26, 2024
* Enable validator client to sign execution payload envelope * Update comment Co-authored-by: JihoonSong <[email protected]> --------- Co-authored-by: JihoonSong <[email protected]>
potuz
pushed a commit
that referenced
this pull request
Oct 7, 2024
* Enable validator client to sign execution payload envelope * Update comment Co-authored-by: JihoonSong <[email protected]> --------- Co-authored-by: JihoonSong <[email protected]>
potuz
pushed a commit
that referenced
this pull request
Oct 14, 2024
* Enable validator client to sign execution payload envelope * Update comment Co-authored-by: JihoonSong <[email protected]> --------- Co-authored-by: JihoonSong <[email protected]>
potuz
pushed a commit
that referenced
this pull request
Oct 16, 2024
* Enable validator client to sign execution payload envelope * Update comment Co-authored-by: JihoonSong <[email protected]> --------- Co-authored-by: JihoonSong <[email protected]>
potuz
pushed a commit
that referenced
this pull request
Oct 22, 2024
* Enable validator client to sign execution payload envelope * Update comment Co-authored-by: JihoonSong <[email protected]> --------- Co-authored-by: JihoonSong <[email protected]>
potuz
pushed a commit
that referenced
this pull request
Oct 28, 2024
* Enable validator client to sign execution payload envelope * Update comment Co-authored-by: JihoonSong <[email protected]> --------- Co-authored-by: JihoonSong <[email protected]>
potuz
pushed a commit
that referenced
this pull request
Nov 1, 2024
* Enable validator client to sign execution payload envelope * Update comment Co-authored-by: JihoonSong <[email protected]> --------- Co-authored-by: JihoonSong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a helper
signExecutionPayloadEnvelopefor validator client to sign execution payload envelope