Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Data Column Verification #14287

Merged
merged 12 commits into from
Aug 12, 2024
Merged

Add Data Column Verification #14287

merged 12 commits into from
Aug 12, 2024

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Aug 1, 2024

What type of PR is this?

Feature

What does this PR do? Why is it needed?

Currently we repeat the validation pipeline for data columns throughout the repository. This PR centralizes all the invocations to the verification package so that it can be reused across prysm. This brings it in line with how its done with blobs and makes it more maintainable in the future as we have a canonical way to validate data columns.

Using these verification methods, we can validate data columns the same way in initial sync and also while back filling.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas requested a review from a team as a code owner August 1, 2024 10:29
@nisdas nisdas requested review from rauljordan, terencechain and james-prysm and removed request for a team August 1, 2024 10:29
@nalepae nalepae added the peerDAS label Aug 2, 2024
nalepae
nalepae reviewed Aug 5, 2024
View reviewed changes
Copy link
Contributor

@nalepae nalepae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't find the implementation of this rule:

[IGNORE] The sidecar is the first sidecar for the tuple (block_header.slot, block_header.proposer_index, sidecar.index) with valid header signature, sidecar inclusion proof, and kzg proof.

nalepae
nalepae reviewed Aug 5, 2024
View reviewed changes
Copy link
Contributor

@nalepae nalepae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validateDataColumn has 0% test coverage.

nalepae
nalepae reviewed Aug 5, 2024
View reviewed changes
Copy link
Contributor

@nalepae nalepae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data_column.go has 0% test coverage.

@nisdas nisdas merged commit 6587b35 into peerDAS Aug 12, 2024
15 of 16 checks passed
@nisdas nisdas deleted the dataColumnValidation branch August 12, 2024 09:09
nisdas added a commit that referenced this pull request Aug 14, 2024
@nisdas
Add Data Column Verification (#14287)
b7777fe 
* Persist All Changes

* Fix All Tests

* Fix Build

* Fix Build

* Fix Build

* Fix Test Again

* Add missing verification

* Add Test Cases for Data Column Validation

* Fix comments for methods

* Fix comments for methods

* Fix Test

* Manu's Review
nisdas added a commit that referenced this pull request Aug 15, 2024
@nisdas
Add Data Column Verification (#14287)
2039508 
* Persist All Changes

* Fix All Tests

* Fix Build

* Fix Build

* Fix Build

* Fix Test Again

* Add missing verification

* Add Test Cases for Data Column Validation

* Fix comments for methods

* Fix comments for methods

* Fix Test

* Manu's Review
nisdas added a commit that referenced this pull request Aug 20, 2024
@nisdas
Add Data Column Verification (#14287)
cf029aa 
* Persist All Changes

* Fix All Tests

* Fix Build

* Fix Build

* Fix Build

* Fix Test Again

* Add missing verification

* Add Test Cases for Data Column Validation

* Fix comments for methods

* Fix comments for methods

* Fix Test

* Manu's Review
@nisdas nisdas mentioned this pull request Aug 23, 2024
Merged
nalepae pushed a commit that referenced this pull request Aug 27, 2024
@nisdas @nalepae
Add Data Column Verification (#14287)
4621146 
* Persist All Changes

* Fix All Tests

* Fix Build

* Fix Build

* Fix Build

* Fix Test Again

* Add missing verification

* Add Test Cases for Data Column Validation

* Fix comments for methods

* Fix comments for methods

* Fix Test

* Manu's Review
nalepae pushed a commit that referenced this pull request Aug 28, 2024
@nisdas @nalepae
Add Data Column Verification (#14287)
f03fccf 
* Persist All Changes

* Fix All Tests

* Fix Build

* Fix Build

* Fix Build

* Fix Test Again

* Add missing verification

* Add Test Cases for Data Column Validation

* Fix comments for methods

* Fix comments for methods

* Fix Test

* Manu's Review
nalepae pushed a commit that referenced this pull request Aug 28, 2024
@nisdas @nalepae
Add Data Column Verification (#14287)
5b87e54 
* Persist All Changes

* Fix All Tests

* Fix Build

* Fix Build

* Fix Build

* Fix Test Again

* Add missing verification

* Add Test Cases for Data Column Validation

* Fix comments for methods

* Fix comments for methods

* Fix Test

* Manu's Review
nalepae pushed a commit that referenced this pull request Oct 7, 2024
@nisdas @nalepae
Add Data Column Verification (#14287)
9bd4371 
* Persist All Changes

* Fix All Tests

* Fix Build

* Fix Build

* Fix Build

* Fix Test Again

* Add missing verification

* Add Test Cases for Data Column Validation

* Fix comments for methods

* Fix comments for methods

* Fix Test

* Manu's Review
nalepae pushed a commit that referenced this pull request Oct 7, 2024
@nisdas @nalepae
Add Data Column Verification (#14287)
ccfede2 
* Persist All Changes

* Fix All Tests

* Fix Build

* Fix Build

* Fix Build

* Fix Test Again

* Add missing verification

* Add Test Cases for Data Column Validation

* Fix comments for methods

* Fix comments for methods

* Fix Test

* Manu's Review
nalepae pushed a commit that referenced this pull request Oct 7, 2024
@nisdas @nalepae
Add Data Column Verification (#14287)
f56f307 
* Persist All Changes

* Fix All Tests

* Fix Build

* Fix Build

* Fix Build

* Fix Test Again

* Add missing verification

* Add Test Cases for Data Column Validation

* Fix comments for methods

* Fix comments for methods

* Fix Test

* Manu's Review
nalepae pushed a commit that referenced this pull request Oct 7, 2024
@nisdas @nalepae
Add Data Column Verification (#14287)
69d6db4 
* Persist All Changes

* Fix All Tests

* Fix Build

* Fix Build

* Fix Build

* Fix Test Again

* Add missing verification

* Add Test Cases for Data Column Validation

* Fix comments for methods

* Fix comments for methods

* Fix Test

* Manu's Review
nalepae pushed a commit that referenced this pull request Oct 8, 2024
@nisdas @nalepae
Add Data Column Verification (#14287)
1b9d130 
* Persist All Changes

* Fix All Tests

* Fix Build

* Fix Build

* Fix Build

* Fix Test Again

* Add missing verification

* Add Test Cases for Data Column Validation

* Fix comments for methods

* Fix comments for methods

* Fix Test

* Manu's Review
nalepae pushed a commit that referenced this pull request Oct 23, 2024
@nisdas @nalepae
Add Data Column Verification (#14287)
d75b898 
* Persist All Changes

* Fix All Tests

* Fix Build

* Fix Build

* Fix Build

* Fix Test Again

* Add missing verification

* Add Test Cases for Data Column Validation

* Fix comments for methods

* Fix comments for methods

* Fix Test

* Manu's Review
nalepae pushed a commit that referenced this pull request Oct 23, 2024
@nisdas @nalepae
Add Data Column Verification (#14287)
c584552 
* Persist All Changes

* Fix All Tests

* Fix Build

* Fix Build

* Fix Build

* Fix Test Again

* Add missing verification

* Add Test Cases for Data Column Validation

* Fix comments for methods

* Fix comments for methods

* Fix Test

* Manu's Review
nalepae pushed a commit that referenced this pull request Oct 24, 2024
@nisdas @nalepae
Add Data Column Verification (#14287)
75f06f4 
* Persist All Changes

* Fix All Tests

* Fix Build

* Fix Build

* Fix Build

* Fix Test Again

* Add missing verification

* Add Test Cases for Data Column Validation

* Fix comments for methods

* Fix comments for methods

* Fix Test

* Manu's Review
nalepae pushed a commit that referenced this pull request Nov 20, 2024
@nisdas @nalepae
Add Data Column Verification (#14287)
147db3e 
* Persist All Changes

* Fix All Tests

* Fix Build

* Fix Build

* Fix Build

* Fix Test Again

* Add missing verification

* Add Test Cases for Data Column Validation

* Fix comments for methods

* Fix comments for methods

* Fix Test

* Manu's Review
nalepae pushed a commit that referenced this pull request Nov 22, 2024
@nisdas @nalepae
Add Data Column Verification (#14287)
041db8b 
* Persist All Changes

* Fix All Tests

* Fix Build

* Fix Build

* Fix Build

* Fix Test Again

* Add missing verification

* Add Test Cases for Data Column Validation

* Fix comments for methods

* Fix comments for methods

* Fix Test

* Manu's Review
nalepae pushed a commit that referenced this pull request Nov 22, 2024
@nisdas @nalepae
Add Data Column Verification (#14287)
13faaf2 
* Persist All Changes

* Fix All Tests

* Fix Build

* Fix Build

* Fix Build

* Fix Test Again

* Add missing verification

* Add Test Cases for Data Column Validation

* Fix comments for methods

* Fix comments for methods

* Fix Test

* Manu's Review
nalepae pushed a commit that referenced this pull request Nov 25, 2024
@nisdas @nalepae
Add Data Column Verification (#14287)
e208491 
* Persist All Changes

* Fix All Tests

* Fix Build

* Fix Build

* Fix Build

* Fix Test Again

* Add missing verification

* Add Test Cases for Data Column Validation

* Fix comments for methods

* Fix comments for methods

* Fix Test

* Manu's Review
nalepae pushed a commit that referenced this pull request Nov 25, 2024
@nisdas @nalepae
Add Data Column Verification (#14287)
ba8eded 
* Persist All Changes

* Fix All Tests

* Fix Build

* Fix Build

* Fix Build

* Fix Test Again

* Add missing verification

* Add Test Cases for Data Column Validation

* Fix comments for methods

* Fix comments for methods

* Fix Test

* Manu's Review
nalepae pushed a commit that referenced this pull request Nov 27, 2024
@nisdas @nalepae
Add Data Column Verification (#14287)
d75a7aa 
* Persist All Changes

* Fix All Tests

* Fix Build

* Fix Build

* Fix Build

* Fix Test Again

* Add missing verification

* Add Test Cases for Data Column Validation

* Fix comments for methods

* Fix comments for methods

* Fix Test

* Manu's Review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalepae nalepae nalepae approved these changes

@rauljordan rauljordan Awaiting requested review from rauljordan rauljordan is a code owner automatically assigned from prysmaticlabs/core-team

@terencechain terencechain Awaiting requested review from terencechain terencechain is a code owner automatically assigned from prysmaticlabs/core-team

@james-prysm james-prysm Awaiting requested review from james-prysm james-prysm is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
peerDAS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nisdas @nalepae