Add a Tracing Wrapper Package #14207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saolyn
force-pushed
the
disableTracingCorrectly
branch
from
e8eb9e0
to
8a4340c
Compare
saolyn
approved these changes
Aug 27, 2024
prestonvanloon
approved these changes
Aug 27, 2024
james-prysm
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Adds a wrapper package * Gazelle * Add in Empty Span * Revert It Back * Add back reference * Set It As Empty * fix missing import * remove redundant alias * remove unused --------- Co-authored-by: Sammy Rosso <[email protected]> Co-authored-by: Saolyn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Optimization
What does this PR do? Why is it needed?
In the event a prysm node has disabled tracing, there is no need for the node to execute tracing related tasks while processing messages from gossip. In certain high traffic topics, this brings in an unnecessary load on the node which is not necessary. This PR introduces a wrapper package which creates an empty span in the event we do not want to run any tracing related paths.
Which issues(s) does this PR fix?
Fixes #
Other notes for review