Holesky support #12821
Holesky support #12821
Conversation
prestonvanloon
force-pushed
the
holesky
branch
2 times, most recently
from
dfcf88b
to
5d98a67
Compare
Copy config/params from deneb-integration
prestonvanloon
force-pushed
the
holesky
branch
from
70b808a
to
797e486
Compare
| if errors.Is(err, stategen.ErrNoGenesisBlock) { | ||
| log.Errorf("No genesis block/state is found. Prysm only provides a mainnet genesis "+ | ||
| "state bundled in the application. You must provide the --%s or --%s flag to load "+ | ||
| "a genesis block/state for this network.", "genesis-state", "genesis-beacon-api-url") |
There was a problem hiding this comment.
I see you used variable interpolation for the flag names - did you intend to replace these with direct flag var .Name references?
There was a problem hiding this comment.
I tried this and got hit with a circular dep. I would have to refactor / move those flags to another package so I just hard coded it in the laziest way. I could remove the templating if that's your feedback here.
There was a problem hiding this comment.
Makes sense, in that case, yes the templating seems to introduce a smidge of confusion for no discernible benefit, but I don't feel strongly about it.
| @@ -154,6 +161,10 @@ func applyPraterFeatureFlags(ctx *cli.Context) { | |||
| func applySepoliaFeatureFlags(ctx *cli.Context) { | |||
| } | |||
|
|
|||
| // Insert feature flags within the function to be enabled for Holesky testnet. | |||
| func applyHoleskyFeatureFlags(ctx *cli.Context) { | |||
There was a problem hiding this comment.
i think deepsource is complaining these parameters are not used
There was a problem hiding this comment.
I think it's fine. These are essentially reserved functions for future use anyway
There was a problem hiding this comment.
This looks good to me
@prestonvanloon will you be updating the prysm docs? if not, we should get an owner on that task?
@terencechain -- yes, i will update docs as well. #12724 as assigned to me and we have a task item there. |
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Adds holesky config support for the upcoming holesky testnet.
The holesky genesis state is far too large to bundle inside of the prysm distribution binary (200Mb) so it must be loaded from disk or checkpoint sync. This is existing behavior for other testnets, but I felt it would be helpful to provide a meaningful failure message when the user attempts to run prysm on a non-mainnet network.
Which issues(s) does this PR fix?
#12724
Other notes for review
Example of running Prysm without a genesis state