Add deneb config/params from deneb-integration #12783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
force-pushed
the
deneb-config
branch
from
b181917
to
b24b763
Compare
prestonvanloon
commented
Aug 23, 2023
| @@ -130,6 +131,7 @@ func TestModifiedE2E(t *testing.T) { | |||
| c.TerminalTotalDifficulty = "0" | |||
| c.AltairForkEpoch = 0 | |||
| c.BellatrixForkEpoch = 0 | |||
| c.DenebForkEpoch = 358 | |||
There was a problem hiding this comment.
Not sure what to put here. deneb-integration was quite different.
See:
prestonvanloon
force-pushed
the
deneb-config
branch
from
b24b763
to
38928f4
Compare
terencechain
previously approved these changes
Aug 23, 2023
james-prysm
reviewed
Aug 23, 2023
Co-authored-by: Terence Tsao <[email protected]> Co-authored-by: Kasey Kirkham <[email protected]>
prestonvanloon
force-pushed
the
deneb-config
branch
from
38928f4
to
73a0b55
Compare
kasey
approved these changes
Aug 23, 2023
Merged
saolyn
pushed a commit
that referenced
this pull request
Aug 29, 2023
Co-authored-by: Terence Tsao <[email protected]> Co-authored-by: Kasey Kirkham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
This adds the config/params changes from the deneb-integration branch.
Which issues(s) does this PR fix?
Required to add holesky testnet config (#12724).
Other notes for review