Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deneb: publishblockv2 endpoint #12662

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Deneb: publishblockv2 endpoint #12662

merged 1 commit into from
Jul 26, 2023

Conversation

james-prysm
Copy link
Contributor

What type of PR is this?

Feature

What does this PR do? Why is it needed?

Implements the following, unit test values should be updated with sample data instead of using mock data.

Implements the following APIs for Deneb

  • publishBlindedBlockV2 json
  • publishBlindedBlockV2 ssz
  • publishBlockV2 json
  • publishBlockV2 ssz

Which issues(s) does this PR fix?

part of #12248

@james-prysm james-prysm added the Deneb PRs or issues for the Deneb upgrade label Jul 25, 2023
@james-prysm james-prysm requested a review from a team as a code owner July 25, 2023 19:07
@james-prysm james-prysm self-assigned this Jul 25, 2023
@james-prysm james-prysm requested review from prestonvanloon, saolyn and potuz and removed request for a team July 25, 2023 19:07
james-prysm
james-prysm commented Jul 25, 2023
View reviewed changes
beacon-chain/rpc/eth/beacon/handlers_test.go
require.NoError(t, err)
genericBlock, err := dblock.ToGeneric()
require.NoError(t, err)
v2block, err := migration.V1Alpha1SignedBeaconBlockDenebAndBlobsToV2(genericBlock.GetDeneb())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should just have blockandblobs ssz marshalable instead...

rkapka
rkapka previously requested changes Jul 26, 2023
View reviewed changes
beacon-chain/rpc/eth/beacon/handlers.go Show resolved Hide resolved
beacon-chain/rpc/eth/beacon/handlers.go Show resolved Hide resolved
beacon-chain/rpc/eth/beacon/handlers.go Show resolved Hide resolved
beacon-chain/rpc/eth/beacon/handlers.go Show resolved Hide resolved
@rkapka rkapka dismissed their stale review July 26, 2023 16:22

my mistake

@james-prysm james-prysm merged commit 6a3f98b into deneb-integration Jul 26, 2023
5 checks passed
@james-prysm james-prysm deleted the deneb-publish-blockv2 branch July 26, 2023 16:46
james-prysm added a commit that referenced this pull request Aug 4, 2023
@james-prysm
implementing publishblockv2 for deneb (#12662)
0f1b020
terencechain pushed a commit that referenced this pull request Aug 4, 2023
@james-prysm @terencechain
implementing publishblockv2 for deneb (#12662)
9df97d5
james-prysm added a commit that referenced this pull request Aug 8, 2023
@james-prysm
implementing publishblockv2 for deneb (#12662)
4c352fa
james-prysm added a commit that referenced this pull request Aug 9, 2023
@james-prysm
implementing publishblockv2 for deneb (#12662)
b95f390
james-prysm added a commit that referenced this pull request Aug 14, 2023
@james-prysm
implementing publishblockv2 for deneb (#12662)
1634d6d
terencechain pushed a commit that referenced this pull request Aug 16, 2023
@james-prysm @terencechain
implementing publishblockv2 for deneb (#12662)
15bcbeb
kasey pushed a commit that referenced this pull request Aug 21, 2023
@james-prysm @kasey
implementing publishblockv2 for deneb (#12662)
32ab53d
kasey pushed a commit that referenced this pull request Aug 22, 2023
@james-prysm @kasey
implementing publishblockv2 for deneb (#12662)
84fa988
kasey pushed a commit that referenced this pull request Aug 22, 2023
@james-prysm @kasey
implementing publishblockv2 for deneb (#12662)
6550491
kasey pushed a commit that referenced this pull request Aug 22, 2023
@james-prysm @kasey
implementing publishblockv2 for deneb (#12662)
f73257a
kasey pushed a commit that referenced this pull request Aug 23, 2023
@james-prysm @kasey
implementing publishblockv2 for deneb (#12662)
35effc6
kasey pushed a commit that referenced this pull request Aug 23, 2023
@james-prysm @kasey
implementing publishblockv2 for deneb (#12662)
49376da
kasey pushed a commit that referenced this pull request Aug 23, 2023
@james-prysm @kasey
implementing publishblockv2 for deneb (#12662)
da8b71e
kasey pushed a commit that referenced this pull request Aug 24, 2023
@james-prysm @kasey
implementing publishblockv2 for deneb (#12662)
0ac5c1b
kasey pushed a commit that referenced this pull request Aug 24, 2023
@james-prysm @kasey
implementing publishblockv2 for deneb (#12662)
1f8a110
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@james-prysm @prestonvanloon
implementing publishblockv2 for deneb (#12662)
95ac063
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@james-prysm @prestonvanloon
implementing publishblockv2 for deneb (#12662)
bd6f46a
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@james-prysm @prestonvanloon
implementing publishblockv2 for deneb (#12662)
9ef62fa
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@james-prysm @prestonvanloon
implementing publishblockv2 for deneb (#12662)
53aa07d
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@james-prysm @prestonvanloon
implementing publishblockv2 for deneb (#12662)
462e311
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@james-prysm @prestonvanloon
implementing publishblockv2 for deneb (#12662)
5e47a61
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@james-prysm @prestonvanloon
implementing publishblockv2 for deneb (#12662)
2275f32
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@james-prysm @prestonvanloon
implementing publishblockv2 for deneb (#12662)
c23903a
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@james-prysm @prestonvanloon
implementing publishblockv2 for deneb (#12662)
fdcc065
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@james-prysm @prestonvanloon
implementing publishblockv2 for deneb (#12662)
7f9d611 
fixing broken test (#12673)
prestonvanloon pushed a commit that referenced this pull request Aug 24, 2023
@james-prysm @prestonvanloon
implementing publishblockv2 for deneb (#12662)
5595cdc 
fixing broken test (#12673)
prestonvanloon pushed a commit that referenced this pull request Aug 30, 2023
@james-prysm @prestonvanloon
implementing publishblockv2 for deneb (#12662)
24428b8 
fixing broken test (#12673)
prestonvanloon pushed a commit that referenced this pull request Aug 30, 2023
@james-prysm @prestonvanloon
implementing publishblockv2 for deneb (#12662)
3fd3bcb 
fixing broken test (#12673)
prestonvanloon pushed a commit that referenced this pull request Aug 31, 2023
@james-prysm @prestonvanloon
implementing publishblockv2 for deneb (#12662)
f602a44 
fixing broken test (#12673)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terencechain terencechain terencechain approved these changes

@rkapka rkapka rkapka left review comments

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon prestonvanloon is a code owner automatically assigned from prysmaticlabs/core-team

@saolyn saolyn Awaiting requested review from saolyn saolyn is a code owner automatically assigned from prysmaticlabs/core-team

@potuz potuz Awaiting requested review from potuz potuz is a code owner automatically assigned from prysmaticlabs/core-team

Assignees

@james-prysm james-prysm

Labels
Deneb PRs or issues for the Deneb upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@james-prysm @terencechain @rkapka