eip4844: beacon api updates #12234
Merged
eip4844: beacon api updates #12234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
# Conflicts: # beacon-chain/rpc/prysm/v1alpha1/validator/proposer.go # beacon-chain/rpc/prysm/v1alpha1/validator/proposer_bellatrix_test.go # beacon-chain/rpc/prysm/v1alpha1/validator/proposer_capella_test.go # beacon-chain/rpc/prysm/v1alpha1/validator/unblinder.go
rkapka
requested review from
saolyn,
terencechain and
james-prysm
and removed request for
a team
james-prysm
reviewed
Apr 7, 2023
| @@ -138,25 +147,29 @@ func (bs *Server) GetBlindedBlockSSZ(ctx context.Context, req *ethpbv1.BlockRequ | |||
| // successful. The beacon node is expected to integrate the new block into its state, and | |||
| // therefore validate the block internally, however blocks which fail the validation are still | |||
| // broadcast but a different status code is returned (202). | |||
| func (bs *Server) SubmitBlindedBlock(ctx context.Context, req *ethpbv2.SignedBlindedBeaconBlockContainer) (*emptypb.Empty, error) { | |||
| func (bs *Server) SubmitBlindedBlock(ctx context.Context, req *ethpbv2.SignedBlindedBeaconBlockContentsContainer) (*emptypb.Empty, error) { | |||
There was a problem hiding this comment.
we should align on this name and this type *ethpbv2.SignedBlindedBeaconBlockContentsContainer i do something similar in my PR...
rkapka
force-pushed
the
eip4844-updateapi
branch
from
bf0312e
to
d7cedd8
Compare
james-prysm
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the following from #12248:
getBlindedBlockjsonpublishBlindedBlockjson