prysm.sh download only option #5628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farazdagi
added
OK to merge
Ready For Review
terencechain
approved these changes
Apr 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
--download-onlyoption, so that./prysm.sh beacon-chain --download-onlyor./prysm.sh validator --download-only, checks for updated version, downloads and verifies it, and stops on that - w/o starting (beacon/validator/slasher) node.Which issues(s) does this PR fix?
Fixes #5580
Other notes for review
./prysm.sh update, which would update all the binaries, but it didn't seem to be the most flexible way. With--download-onlyflag we can update any binary (or all three./prysm beacon-chain --download-only && ./prysm validator --download-only && ./prysm.sh slasher --download-onlyeffectively having the./prysm.sh updatefunctionality), and we do not need to amend internal logic of the script (where script is the wrapper for some process: validator, beacon-chain, or slasher node).