Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update option in prysm.sh #5580

Closed
Yoldark34 opened this issue Apr 22, 2020 · 2 comments · Fixed by #5628
Closed

Add update option in prysm.sh #5580

Yoldark34 opened this issue Apr 22, 2020 · 2 comments · Fixed by #5628
Assignees
Labels
Enhancement New feature or request Good First Issue Good for newcomers Help Wanted Extra attention is needed

Comments

@Yoldark34
Copy link

Yoldark34 commented Apr 22, 2020

🚀 Feature Request

Description

The option allow to update beacon and validator files without the need to restart them before.
In order to gain time and avoid putting node offline for too long it is a good idea to update the process in background and then restart the beacon/validator.
At the actual state of prysm.sh this solution is already feasible.

prysm.sh update

It will update the beacon and the validator without the need of shutting them down. Then it will throw an error because the command is not defined.

user@user:~$ prysm/prysm.sh update
Latest Prysm version is v1.0.0-alpha.5.
Beacon chain is up to date.
Validator is up to date.
Usage: ./prysm.sh PROCESS FLAGS.
PROCESS can be beacon-chain or validator.
Starting Prysm update
prysm/prysm.sh: ligne 152: process : variable sans liaison

Implementing the command to display a success message or nothing is enough for the feature to work.
The user may then restart the node the way that it choose to.

Describe the solution you'd like

Implement the update option in prysm.sh script file
It should display as this :

user@user:~$ prysm/prysm.sh update
Latest Prysm version is v1.0.0-alpha.5.
Beacon chain is up to date.
Validator is up to date.

or do the update if needed.

Describe alternatives you've considered

We do nothing as it kind of work by itself.

@prestonvanloon
Copy link
Member

We were also considering whether or not Prysm itself could download the binary in the background and periodically recommend to the user to restart the process.

In any case, I support your proposal to download the latest binaries without starting the process so that the end user can minimize their downtime.

@prestonvanloon prestonvanloon added Enhancement New feature or request Good First Issue Good for newcomers Help Wanted Extra attention is needed labels Apr 23, 2020
@Yoldark34
Copy link
Author

If you want to make the download available in the background you must add the option to disable it as it may not be the best solution to every person.
And you will still need a way to download it by user command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Good First Issue Good for newcomers Help Wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants